Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark a new test as NativeAotIncompatible #88176

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

MichalStrehovsky
Copy link
Member

We don't intend to implement non-intrinsic expansion of GetSpanDataFrom, same as InitializeArray.

Cc @dotnet/ilc-contrib

We don't intend to implement non-intrinsic expansion of GetSpanDataFrom, same as InitializeArray.
@ghost
Copy link

ghost commented Jun 29, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

We don't intend to implement non-intrinsic expansion of GetSpanDataFrom, same as InitializeArray.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas jkotas merged commit 15c5f8b into main Jun 29, 2023
@jkotas jkotas deleted the MichalStrehovsky-patch-3 branch June 29, 2023 05:25
@jkotas
Copy link
Member

jkotas commented Jun 29, 2023

I just tried to run tests locally and I see number of tests failing the build with aot and trimming analyzer errors. Do you have a local fix for it that you plan to PR?

@MichalStrehovsky
Copy link
Member Author

I just tried to run tests locally and I see number of tests failing the build with aot and trimming analyzer errors. Do you have a local fix for it that you plan to PR?

I don't see those errors locally (I just did a test run a couple hours ago).

Or do we also WarnAsError for test build now? (I do have the "please don't waste my time" environment variable set on all my machines so the warnings don't fail the build for me.)

@jkotas
Copy link
Member

jkotas commented Jun 29, 2023

Yes, WarnAsError is enabled for parts of the test build now. I am seeing errors like:

C:\runtime\artifacts\tests\coreclr\obj\windows.x64.Checked\Managed\JIT\HardwareIntrinsics\General\Vector128_1\Vector128
_1_r\Vector128_1_r\gen\AsVector.Int32.cs(76,39): error IL2060: Call to 'System.Reflection.MethodInfo.MakeGenericMethod(
params Type[])' can not be statically analyzed. It's not possible to guarantee the availability of requirements of the
generic method. [C:\runtime\src\tests\JIT\HardwareIntrinsics\General\Vector128_1\Vector128_1_r.csproj] [C:\runtime\src\
tests\build.proj]

@jkotas
Copy link
Member

jkotas commented Jun 29, 2023

#88209

@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants